Commit 9ff68186 authored Nov 21, 2015 by Lars-Peter Clausen Committed by Vinod Koul Dec 05, 2015

dmaengine: img-mdc: Remove unnecessary synchronize_irq() before devm_free_irq()



Calling synchronize_irq() right before devm_free_irq() is quite useless. On
one hand the IRQ can easily fire again before devm_free_irq() is entered,
on the other hand devm_free_irq() itself calls synchronize_irq() internally
(in a race condition free way), before any state associated with the IRQ is
freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq, dev;
@@
-synchronize_irq(irq);
 devm_free_irq(dev, irq, ...);
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 1f281792

drivers/dma/img-mdc-dma.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -979,7 +979,6 @@ static int mdc_dma_remove(struct platform_device *pdev)
	vc.chan.device_node) {		vc.chan.device_node) {
	list_del(&mchan->vc.chan.device_node);		list_del(&mchan->vc.chan.device_node);

	synchronize_irq(mchan->irq);
	devm_free_irq(&pdev->dev, mchan->irq, mchan);		devm_free_irq(&pdev->dev, mchan->irq, mchan);

	tasklet_kill(&mchan->vc.task);		tasklet_kill(&mchan->vc.task);