Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d380190 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: mos7840: replace unnecessary atomic allocations 



Use GFP_KERNEL instead of GFP_ATOMIC for allocations in set_termios and
port-setting helper which both may and do sleep.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 1dbd11be

drivers/usb/serial/mos7840.c

+2 −2
Original line number Diff line number Diff line
@@ -1904,7 +1904,7 @@ static void mos7840_change_port_settings(struct tty_struct *tty, 


	if (mos7840_port->read_urb_busy == false) {

		mos7840_port->read_urb_busy = true;

		status = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC);

		status = usb_submit_urb(mos7840_port->read_urb, GFP_KERNEL);

		if (status) {

			dev_dbg(&port->dev, "usb_submit_urb(read bulk) failed, status = %d\n",

			    status);
@@ -1968,7 +1968,7 @@ static void mos7840_set_termios(struct tty_struct *tty, 


	if (mos7840_port->read_urb_busy == false) {

		mos7840_port->read_urb_busy = true;

		status = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC);

		status = usb_submit_urb(mos7840_port->read_urb, GFP_KERNEL);

		if (status) {

			dev_dbg(&port->dev, "usb_submit_urb(read bulk) failed, status = %d\n",

			    status);