Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9941a862 authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme: Suppress static analyis warning 



The ns->head is always valid, so we don't need to check for NULL.

Reported-by: default avatarDan Carpenter <dan.caprenter@oracle.com>
Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent b0d61d58

drivers/nvme/host/core.c

+2 −5
Original line number Diff line number Diff line
@@ -2961,8 +2961,6 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid) 


static void nvme_ns_remove(struct nvme_ns *ns)

{

	struct nvme_ns_head *head = ns->head;



	if (test_and_set_bit(NVME_NS_REMOVING, &ns->flags))

		return;
@@ -2980,7 +2978,6 @@ static void nvme_ns_remove(struct nvme_ns *ns) 


	mutex_lock(&ns->ctrl->subsys->lock);

	nvme_mpath_clear_current_path(ns);

	if (head)

	list_del_rcu(&ns->siblings);

	mutex_unlock(&ns->ctrl->subsys->lock);
@@ -2988,7 +2985,7 @@ static void nvme_ns_remove(struct nvme_ns *ns) 
	list_del_init(&ns->list);

	mutex_unlock(&ns->ctrl->namespaces_mutex);



	synchronize_srcu(&head->srcu);

	synchronize_srcu(&ns->head->srcu);

	nvme_put_ns(ns);

}