Commit 98d49bc3 authored Feb 12, 2024 by Rob Clark Committed by Greg Kroah-Hartman Nov 08, 2024

drm/crtc: fix uninitialized variable use even harder



[ Upstream commit b6802b61a9d0e99dcfa6fff7c50db7c48a9623d3 ]

DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop),
which means we can't rely too much on variable initializers.

Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # sc7180, sdm845
Link: https://patchwork.freedesktop.org/patch/msgid/20240212215534.190682-1-robdclark@gmail.com


Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 831d8d67

drivers/gpu/drm/drm_crtc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -768,6 +768,7 @@ int drm_mode_setcrtc(struct drm_device dev, void data,
		connector_set = NULL;
		fb = NULL;
		mode = NULL;
		num_connectors = 0;

		if (ret == -EDEADLK) {
		ret = drm_modeset_backoff(&ctx);