Commit 96c26e04 authored Aug 20, 2018 by Prashant Bhole Committed by Daniel Borkmann Aug 21, 2018

xsk: fix return value of xdp_umem_assign_dev()



s/ENOTSUPP/EOPNOTSUPP/ in function umem_assign_dev().
This function's return value is directly returned by xsk_bind().
EOPNOTSUPP is bind()'s possible return value.

Fixes: f734607e ("xsk: refactor xdp_umem_assign_dev()")
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Acked-by: Song Liu <songliubraving@fb.com>
Acked-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent b93c1b5a

net/xdp/xdp_umem.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -74,14 +74,14 @@ int xdp_umem_assign_dev(struct xdp_umem umem, struct net_device dev,
		return 0;

		if (!dev->netdev_ops->ndo_bpf \|\| !dev->netdev_ops->ndo_xsk_async_xmit)
		return force_zc ? -ENOTSUPP : 0; /* fail or fallback */
		return force_zc ? -EOPNOTSUPP : 0; /* fail or fallback */

		bpf.command = XDP_QUERY_XSK_UMEM;

		rtnl_lock();
		err = xdp_umem_query(dev, queue_id);
		if (err) {
		err = err < 0 ? -ENOTSUPP : -EBUSY;
		err = err < 0 ? -EOPNOTSUPP : -EBUSY;
		goto err_rtnl_unlock;
		}