Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9597c13b authored by Jeff Layton's avatar Jeff Layton Committed by Trond Myklebust
Browse files

nfs: verify open flags before allowing an atomic open 



Currently, you can open a NFSv4 file with O_APPEND|O_DIRECT, but cannot
fcntl(F_SETFL,...) with those flags. This flag combination is explicitly
forbidden on NFSv3 opens, and it seems like it should also be on NFSv4.

Reported-by: default avatarChao Ye <cye@redhat.com>
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 55b59293

fs/nfs/dir.c

+4 −0
Original line number Diff line number Diff line
@@ -1413,6 +1413,10 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry, 
	dfprintk(VFS, "NFS: atomic_open(%s/%ld), %s\n",

			dir->i_sb->s_id, dir->i_ino, dentry->d_name.name);



	err = nfs_check_flags(open_flags);

	if (err)

		return err;



	/* NFS only supports OPEN on regular files */

	if ((open_flags & O_DIRECTORY)) {

		if (!d_unhashed(dentry)) {