Commit 9585f444 authored Aug 14, 2019 by Hui Wang Committed by Greg Kroah-Hartman Aug 25, 2019

ALSA: hda - Let all conexant codec enter D3 when rebooting



commit 401714d9534aad8c24196b32600da683116bbe09 upstream.

We have 3 new lenovo laptops which have conexant codec 0x14f11f86,
these 3 laptops also have the noise issue when rebooting, after
letting the codec enter D3 before rebooting or poweroff, the noise
disappers.

Instead of adding a new ID again in the reboot_notify(), let us make
this function apply to all conexant codec. In theory make codec enter
D3 before rebooting or poweroff is harmless, and I tested this change
on a couple of other Lenovo laptops which have different conexant
codecs, there is no side effect so far.

Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e58ba88d

sound/pci/hda/patch_conexant.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -176,15 +176,6 @@ static void cx_auto_reboot_notify(struct hda_codec *codec)
		{
		struct conexant_spec *spec = codec->spec;

		switch (codec->core.vendor_id) {
		case 0x14f12008: /* CX8200 */
		case 0x14f150f2: /* CX20722 */
		case 0x14f150f4: /* CX20724 */
		break;
		default:
		return;
		}

		/* Turn the problematic codec into D3 to avoid spurious noises
		from the internal speaker during (and after) reboot */
		cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);