Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9498553d authored by Aditya Bavanari's avatar Aditya Bavanari Committed by Gerrit - the friendly Code Review server
Browse files

dsp: voice: Remove common lock before sending unmap command 



Remove common mutex lock before invoking unmap physical
memory command to avoid deadlock issue between voice lock
and common lock in concurrency use cases.

Change-Id: Iaca089f4ff1b6da16e0e59939088fb59516362aa
Signed-off-by: default avatarAditya Bavanari <abavanar@codeaurora.org>
parent 14575274

dsp/q6voice.c

+0 −2
Original line number Diff line number Diff line
@@ -1276,7 +1276,6 @@ static int voice_unmap_cal_block(struct voice_data *v, int cal_index) 
		goto unlock;

	}



	mutex_lock(&common.common_lock);

	result = voice_send_mvm_unmap_memory_physical_cmd(

		v, cal_block->map_data.q6map_handle);

	if (result)
@@ -1284,7 +1283,6 @@ static int voice_unmap_cal_block(struct voice_data *v, int cal_index) 
			__func__, v->session_id, result);



	cal_block->map_data.q6map_handle = 0;

	mutex_unlock(&common.common_lock);

unlock:

	mutex_unlock(&common.cal_data[cal_index]->lock);

done: