Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 946a88df authored by Julia Lawall's avatar Julia Lawall Committed by Stephen Warren
Browse files

tegra: simplify use of devm_ioremap_resource 

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
parent ad81f054

drivers/iommu/tegra-smmu.c

+0 −2
Original line number Diff line number Diff line
@@ -1177,8 +1177,6 @@ static int tegra_smmu_probe(struct platform_device *pdev) 
		struct resource *res;



		res = platform_get_resource(pdev, IORESOURCE_MEM, i);

		if (!res)

			return -ENODEV;

		smmu->regs[i] = devm_ioremap_resource(&pdev->dev, res);

		if (IS_ERR(smmu->regs[i]))

			return PTR_ERR(smmu->regs[i]);

drivers/memory/tegra20-mc.c

+0 −2
Original line number Diff line number Diff line
@@ -218,8 +218,6 @@ static int tegra20_mc_probe(struct platform_device *pdev) 
		struct resource *res;



		res = platform_get_resource(pdev, IORESOURCE_MEM, i);

		if (!res)

			return -ENODEV;

		mc->regs[i] = devm_ioremap_resource(&pdev->dev, res);

		if (IS_ERR(mc->regs[i]))

			return PTR_ERR(mc->regs[i]);

drivers/memory/tegra30-mc.c

+0 −2
Original line number Diff line number Diff line
@@ -340,8 +340,6 @@ static int tegra30_mc_probe(struct platform_device *pdev) 
		struct resource *res;



		res = platform_get_resource(pdev, IORESOURCE_MEM, i);

		if (!res)

			return -ENODEV;

		mc->regs[i] = devm_ioremap_resource(&pdev->dev, res);

		if (IS_ERR(mc->regs[i]))

			return PTR_ERR(mc->regs[i]);