Commit 9414b6e2 authored Jun 16, 2015 by Russell King Committed by Thomas Gleixner Jun 18, 2015

irq: irq-keystone: Fix race in installing chained IRQ handler



Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/E1Z4z0S-0002Ss-1V@rmk-PC.arm.linux.org.uk


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent e88d251d

drivers/irqchip/irq-keystone.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -184,8 +184,7 @@ static int keystone_irq_probe(struct platform_device *pdev)

	platform_set_drvdata(pdev, kirq);		platform_set_drvdata(pdev, kirq);

	irq_set_chained_handler(kirq->irq, keystone_irq_handler);		irq_set_chained_handler_and_data(kirq->irq, keystone_irq_handler, kirq);
	irq_set_handler_data(kirq->irq, kirq);

	/* clear all source bits */		/* clear all source bits */
	keystone_irq_writel(kirq, ~0x0);		keystone_irq_writel(kirq, ~0x0);