Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93719d26 authored by Ivan Vecera's avatar Ivan Vecera Committed by David S. Miller
Browse files

bna: correct comparisons/assignments to bool 



Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2a2d75c0

drivers/net/ethernet/brocade/bna/bfa_ioc.c

+4 −4
Original line number Diff line number Diff line
@@ -1373,7 +1373,7 @@ static enum bfi_ioc_img_ver_cmp 
bfa_ioc_fw_ver_patch_cmp(struct bfi_ioc_image_hdr *base_fwhdr,

			 struct bfi_ioc_image_hdr *fwhdr_to_cmp)

{

	if (bfa_ioc_fw_ver_compatible(base_fwhdr, fwhdr_to_cmp) == false)

	if (!bfa_ioc_fw_ver_compatible(base_fwhdr, fwhdr_to_cmp))

		return BFI_IOC_IMG_VER_INCOMP;



	if (fwhdr_to_cmp->fwver.patch > base_fwhdr->fwver.patch)
@@ -1384,7 +1384,7 @@ bfa_ioc_fw_ver_patch_cmp(struct bfi_ioc_image_hdr *base_fwhdr, 
	/* GA takes priority over internal builds of the same patch stream.

	 * At this point major minor maint and patch numbers are same.

	 */

	if (fwhdr_is_ga(base_fwhdr) == true)

	if (fwhdr_is_ga(base_fwhdr))

		if (fwhdr_is_ga(fwhdr_to_cmp))

			return BFI_IOC_IMG_VER_SAME;

		else
@@ -2209,7 +2209,7 @@ bfa_nw_ioc_smem_read(struct bfa_ioc *ioc, void *tbuf, u32 soff, u32 sz) 
	/*

	 *  Hold semaphore to serialize pll init and fwtrc.

	*/

	if (bfa_nw_ioc_sem_get(ioc->ioc_regs.ioc_init_sem_reg) == 0)

	if (!bfa_nw_ioc_sem_get(ioc->ioc_regs.ioc_init_sem_reg))

		return 1;



	writel(pgnum, ioc->ioc_regs.host_page_num_fn);
@@ -2264,7 +2264,7 @@ bfa_nw_ioc_debug_save_ftrc(struct bfa_ioc *ioc) 
	int tlen;



	if (ioc->dbg_fwsave_once) {

		ioc->dbg_fwsave_once = 0;

		ioc->dbg_fwsave_once = false;

		if (ioc->dbg_fwsave_len) {

			tlen = ioc->dbg_fwsave_len;

			bfa_nw_ioc_debug_fwtrc(ioc, ioc->dbg_fwsave, &tlen);