Commit 92425c40 authored Dec 05, 2017 by Dan Carpenter Committed by David S. Miller Dec 06, 2017

bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()



Smatch warns that:

    drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
    error: uninitialized symbol 'rc'.

"rc" is either uninitialized or set to zero here so we can just remove
the check.

Fixes: 8c95f773 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b9f24204

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
		}
		}

		if (rc)
		return rc;

		if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) {
		if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) {
		/* dst_fid is PF's fid */
		@@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
		}
		}

		return rc;
		return 0;
		}

		#define GET_KEY(flow_cmd, key_type) \