Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91972724 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: garmin_gps: remove bogus disconnect test in close 



Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7620c33a

drivers/usb/serial/garmin_gps.c

+0 −4
Original line number Original line Diff line number Diff line
@@ -946,16 +946,12 @@ static int garmin_open(struct tty_struct *tty, struct usb_serial_port *port) 




static void garmin_close(struct usb_serial_port *port)

static void garmin_close(struct usb_serial_port *port)

{

{

	struct usb_serial *serial = port->serial;

	struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);

	struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);





	dev_dbg(&port->dev, "%s - port %d - mode=%d state=%d flags=0x%X\n",

	dev_dbg(&port->dev, "%s - port %d - mode=%d state=%d flags=0x%X\n",

		__func__, port->number, garmin_data_p->mode,

		__func__, port->number, garmin_data_p->mode,

		garmin_data_p->state, garmin_data_p->flags);

		garmin_data_p->state, garmin_data_p->flags);





	if (!serial)

		return;



	garmin_clear(garmin_data_p);

	garmin_clear(garmin_data_p);





	/* shutdown our urbs */

	/* shutdown our urbs */