Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90ffc1ec authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: rsnd: fixup for_each_rsnd_mod_array{s} iterator increment 



commit 5f222a29 ("ASoC: rsnd: use for_each_rsnd_mod_xxx() ...")
modifies rsnd_dai_call() to use for_each_rsnd_mod_arrays().

Current rsnd is incrementing iterator in rsnd_mod_next(),
but the iterator will indicate +1 position in for_each loop in
this case. Incremental position should be inside for()

Reported-by: default avatarHoan Nguyen An <na-hoan@jinso.co.jp>
Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a5de5b74

sound/soc/sh/rcar/core.c

+0 −2
Original line number Diff line number Diff line
@@ -363,8 +363,6 @@ struct rsnd_mod *rsnd_mod_next(int *iterator, 
		if (!mod)

			continue;



		(*iterator)++;



		return mod;

	}

sound/soc/sh/rcar/rsnd.h

+2 −2
Original line number Diff line number Diff line
@@ -374,10 +374,10 @@ struct rsnd_mod *rsnd_mod_next(int *iterator, 
			       int array_size);

#define for_each_rsnd_mod(iterator, pos, io)				\

	for (iterator = 0;						\

	     (pos = rsnd_mod_next(&iterator, io, NULL, 0));)

	     (pos = rsnd_mod_next(&iterator, io, NULL, 0)); iterator++)

#define for_each_rsnd_mod_arrays(iterator, pos, io, array, size)	\

	for (iterator = 0;						\

	     (pos = rsnd_mod_next(&iterator, io, array, size));)

	     (pos = rsnd_mod_next(&iterator, io, array, size)); iterator++)

#define for_each_rsnd_mod_array(iterator, pos, io, array)		\

	for_each_rsnd_mod_arrays(iterator, pos, io, array, ARRAY_SIZE(array))