Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fff39e0 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq: Add missing break in __irq_set_trigger() 



The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.

Reported-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent ed4dea6e

kernel/irq/manage.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, 
		if (chip != desc->irq_data.chip)

		if (chip != desc->irq_data.chip)

			irq_chip_set_defaults(desc->irq_data.chip);

			irq_chip_set_defaults(desc->irq_data.chip);

		ret = 0;

		ret = 0;

		break;

	default:

	default:

		pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",

		pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",

		       flags, irq, chip->irq_set_type);

		       flags, irq, chip->irq_set_type);