Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d71e818 authored by Tariq Toukan's avatar Tariq Toukan Committed by Saeed Mahameed
Browse files

net/mlx5: Use u16 for Work Queue buffer fragment size 



Minimal stride size is 16.
Hence, the number of strides in a fragment (of PAGE_SIZE)
is <= PAGE_SIZE / 16 <= 4K.

u16 is sufficient to represent this.

Fixes: 388ca8be ("IB/mlx5: Implement fragmented completion queue (CQ)")
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Reviewed-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 5df816e7

drivers/net/ethernet/mellanox/mlx5/core/wq.c

+2 −2
Original line number Diff line number Diff line
@@ -39,9 +39,9 @@ u32 mlx5_wq_cyc_get_size(struct mlx5_wq_cyc *wq) 
	return (u32)wq->fbc.sz_m1 + 1;

}



u32 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq)

u16 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq)

{

	return (u32)wq->fbc.frag_sz_m1 + 1;

	return wq->fbc.frag_sz_m1 + 1;

}



u32 mlx5_cqwq_get_size(struct mlx5_cqwq *wq)

drivers/net/ethernet/mellanox/mlx5/core/wq.h

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ int mlx5_wq_cyc_create(struct mlx5_core_dev *mdev, struct mlx5_wq_param *param, 
		       void *wqc, struct mlx5_wq_cyc *wq,

		       struct mlx5_wq_ctrl *wq_ctrl);

u32 mlx5_wq_cyc_get_size(struct mlx5_wq_cyc *wq);

u32 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq);

u16 mlx5_wq_cyc_get_frag_size(struct mlx5_wq_cyc *wq);



int mlx5_wq_qp_create(struct mlx5_core_dev *mdev, struct mlx5_wq_param *param,

		      void *qpc, struct mlx5_wq_qp *wq,

include/linux/mlx5/driver.h

+1 −1
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ struct mlx5_frag_buf { 
struct mlx5_frag_buf_ctrl {

	struct mlx5_frag_buf	frag_buf;

	u32			sz_m1;

	u32			frag_sz_m1;

	u16			frag_sz_m1;

	u32			strides_offset;

	u8			log_sz;

	u8			log_stride;