Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d31cfce authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds
Browse files

checkpatch: check spacing for square brackets 



Check on the spacing before square brackets.  We should only allow spaces
there if this is part of a type definition or an initialialiser.

Signed-off-by: default avatarAndy Whitcroft <apw@shadowen.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e2a763c2

scripts/checkpatch.pl

+11 −0
Original line number Diff line number Diff line
@@ -1435,6 +1435,17 @@ sub process { 
			ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);

		}



# check for spacing round square brackets; allowed:

#  1. with a type on the left -- int [] a;

#  2. at the beginning of a line for slice initialisers -- [0..10] = 5,

		while ($line =~ /(.*?\s)\[/g) {

			my ($where, $prefix) = ($-[1], $1);

			if ($prefix !~ /$Type\s+$/ &&

			    ($where != 0 || $prefix !~ /^.\s+$/)) {

				ERROR("space prohibited before open square bracket '['\n" . $herecurr);

			}

		}



# check for spaces between functions and their parentheses.

		while ($line =~ /($Ident)\s+\(/g) {

			my $name = $1;