Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ce6eb1a authored by David S. Miller's avatar David S. Miller
Browse files

irda: Fix error propagation in ircomm_lmp_connect_response() 



The variable 'ret' is set but unused, and this pointed out that
errors from irlmp_connect_response() are not propagated to the
caller.

Note that this is currently academic since irlmp_connect_response()
always returns 0. :-)

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad637643

net/irda/ircomm/ircomm_lmp.c

+1 −4
Original line number Diff line number Diff line
@@ -75,7 +75,6 @@ static int ircomm_lmp_connect_response(struct ircomm_cb *self, 
				       struct sk_buff *userdata)

{

	struct sk_buff *tx_skb;

	int ret;



	IRDA_DEBUG(0, "%s()\n", __func__ );
@@ -100,9 +99,7 @@ static int ircomm_lmp_connect_response(struct ircomm_cb *self, 
		tx_skb = userdata;

	}



	ret = irlmp_connect_response(self->lsap, tx_skb);



	return 0;

	return irlmp_connect_response(self->lsap, tx_skb);

}



static int ircomm_lmp_disconnect_request(struct ircomm_cb *self,