Commit 8bdb2908 authored Jan 29, 2016 by Arnd Bergmann Committed by David S. Miller Jan 29, 2016

net: nb8800: avoid uninitialized variable warning

The nb8800_poll() function initializes the 'next' variable in the
loop looking for new input data. We know this will be called at
least once because 'budget' is a guaranteed to be a positive number
when we enter the function, but the compiler doesn't know that
and warns when the variable is used later:

drivers/net/ethernet/aurora/nb8800.c: In function 'nb8800_poll':
drivers/net/ethernet/aurora/nb8800.c:350:21: warning: 'next' may be used uninitialized in this function [-Wmaybe-uninitialized]

Changing the 'while() {}' loop to 'do {} while()' makes it obvious
to the compiler what is going on so it no longer warns.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 57e7c8ce

drivers/net/ethernet/aurora/nb8800.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -302,7 +302,7 @@ static int nb8800_poll(struct napi_struct *napi, int budget)
		nb8800_tx_done(dev);

		again:
		while (work < budget) {
		do {
		struct nb8800_rx_buf *rxb;
		unsigned int len;

		@@ -330,7 +330,7 @@ static int nb8800_poll(struct napi_struct *napi, int budget)
		rxd->report = 0;
		last = next;
		work++;
		}
		} while (work < budget);

		if (work) {
		priv->rx_descs[last].desc.config \|= DESC_EOC;