Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bb8b85f authored by Marek Vasut's avatar Marek Vasut Committed by David Woodhouse
Browse files

mtd: m25p80: Fix the Spansion chip detection 



Due to the implementation of the following loop at the end
of jedec_probe():

776         for (tmp = 0; tmp < ARRAY_SIZE(m25p_ids) - 1; tmp++) {
777                 info = (void *)m25p_ids[tmp].driver_data;
778                 if (info->jedec_id == jedec) {
779                         if (info->ext_id != 0 && info->ext_id != ext_jedec)
780                                 continue;
781                         return &m25p_ids[tmp];
782                 }
783         }

In particular line 779 in the above numbering, the chips with ext_id != 0 must
be ordered first in the list of chips (m25p_ids[]).

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent f728598f

drivers/mtd/devices/m25p80.c

+5 −5
Original line number Diff line number Diff line
@@ -665,12 +665,7 @@ static const struct spi_device_id m25p_ids[] = { 
	/* Spansion -- single (large) sector size only, at least

	 * for the chips listed here (without boot sectors).

	 */

	{ "s25sl004a",  INFO(0x010212,      0,  64 * 1024,   8, 0) },

	{ "s25sl008a",  INFO(0x010213,      0,  64 * 1024,  16, 0) },

	{ "s25sl016a",  INFO(0x010214,      0,  64 * 1024,  32, 0) },

	{ "s25sl032a",  INFO(0x010215,      0,  64 * 1024,  64, 0) },

	{ "s25sl032p",  INFO(0x010215, 0x4d00,  64 * 1024,  64, SECT_4K) },

	{ "s25sl064a",  INFO(0x010216,      0,  64 * 1024, 128, 0) },

	{ "s25sl064p",  INFO(0x010216, 0x4d00,  64 * 1024, 128, SECT_4K) },

	{ "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) },

	{ "s25fl256s1", INFO(0x010219, 0x4d01,  64 * 1024, 512, 0) },
@@ -680,6 +675,11 @@ static const struct spi_device_id m25p_ids[] = { 
	{ "s25sl12801", INFO(0x012018, 0x0301,  64 * 1024, 256, 0) },

	{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024,  64, 0) },

	{ "s25fl129p1", INFO(0x012018, 0x4d01,  64 * 1024, 256, 0) },

	{ "s25sl004a",  INFO(0x010212,      0,  64 * 1024,   8, 0) },

	{ "s25sl008a",  INFO(0x010213,      0,  64 * 1024,  16, 0) },

	{ "s25sl016a",  INFO(0x010214,      0,  64 * 1024,  32, 0) },

	{ "s25sl032a",  INFO(0x010215,      0,  64 * 1024,  64, 0) },

	{ "s25sl064a",  INFO(0x010216,      0,  64 * 1024, 128, 0) },

	{ "s25fl016k",  INFO(0xef4015,      0,  64 * 1024,  32, SECT_4K) },

	{ "s25fl064k",  INFO(0xef4017,      0,  64 * 1024, 128, SECT_4K) },