Commit 8adb4786 authored May 04, 2007 by Alan Stern Committed by Greg Kroah-Hartman Jul 12, 2007

USB: don't unsuspend for a new connection



This patch (as889) prevents the hub driver from trying to resume a
port when there is a new connection.  For one thing, the resume is not
needed -- the upcoming port reset will clear the suspend feature
automatically.  For another, on some systems the resume fails and
causes problems.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent b6f6436d

drivers/usb/core/hub.c

+0 −13

Original line number	Diff line number	Diff line
		@@ -2426,19 +2426,6 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
		return;
		}

		#ifdef CONFIG_USB_SUSPEND
		/* If something is connected, but the port is suspended, wake it up. */
		if (portstatus & USB_PORT_STAT_SUSPEND) {
		status = hub_port_resume(hub, port1, NULL);
		if (status < 0) {
		dev_dbg(hub_dev,
		"can't clear suspend on port %d; %d\n",
		port1, status);
		goto done;
		}
		}
		#endif

		for (i = 0; i < SET_CONFIG_TRIES; i++) {
		struct usb_device *udev;