Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a76714d authored by Adam Lee's avatar Adam Lee Committed by Greg Kroah-Hartman
Browse files

staging: ft1000: fix uninitialized return variable in request_code_segment 



The return variable of request_code_segment() is used uninitialized if
the argument boot_case is false, this patch fixes it.

FYI, in ft1000_usb.h: STATUS_SUCCESS 0, and STATUS_FAILURE 0x1001.

Signed-off-by: default avatarAdam Lee <adam8157@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0b71fe36

drivers/staging/ft1000/ft1000-usb/ft1000_download.c

+2 −2
Original line number Diff line number Diff line
@@ -601,11 +601,11 @@ static int request_code_segment(struct ft1000_usb *ft1000dev, u16 **s_file, 
		status = write_blk(ft1000dev, s_file, c_file, word_length);

		/*DEBUG("write_blk returned %d\n", status); */

	} else {

		write_blk_fifo(ft1000dev, s_file, c_file, word_length);

		status = write_blk_fifo(ft1000dev, s_file, c_file, word_length);

		if (ft1000dev->usbboot == 0)

			ft1000dev->usbboot++;

		if (ft1000dev->usbboot == 1)

			ft1000_write_dpram16(ft1000dev,

			status |= ft1000_write_dpram16(ft1000dev,

					DWNLD_MAG1_PS_HDR_LOC, 0, 0);

	}

	return status;