Unverified Commit 8a2278b7 authored Apr 08, 2018 by Nicolin Chen Committed by Mark Brown Apr 16, 2018

ASoC: fsl_esai: Add freq check in set_dai_sysclk()



The freq parameter indicates the physical frequency of an actual
input clock or a desired frequency of an output clock for HCKT/R.
It should never be passed 0. This might cause Division-by-zero.

So this patch adds a check to fix it.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 728815e3

sound/soc/fsl/fsl_esai.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -226,6 +226,12 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
		unsigned long clk_rate;
		int ret;

		if (freq == 0) {
		dev_err(dai->dev, "%sput freq of HCK%c should not be 0Hz\n",
		in ? "in" : "out", tx ? 'T' : 'R');
		return -EINVAL;
		}

		/* Bypass divider settings if the requirement doesn't change */
		if (freq == esai_priv->hck_rate[tx] && dir == esai_priv->hck_dir[tx])
		return 0;