Commit 88bc230d authored May 05, 2016 by Hariprasad S Committed by Doug Ledford May 05, 2016

RDMA/iw_cxgb4: stop ep timer on close failure



In c4iw_ep_disconnect(), if we start the ep timer to begin a close,
but send_halfclose() fails, we need to stop the timer and send a CLOSE
event up to the IWCM before releasing the resources. Otherwise, we can
crash when the ep timer fires if the ep is referencing a previous instance
of the device. This can happen as part of adapter reset/recovery, for
instance.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 9dec900c

drivers/infiniband/hw/cxgb4/cm.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -3467,9 +3467,14 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)
		set_bit(EP_DISC_CLOSE, &ep->com.history);
		ret = send_halfclose(ep, gfp);
		}
		if (ret)
		if (ret) {
		if (!abrupt) {
		stop_ep_timer(ep);
		close_complete_upcall(ep, -EIO);
		}
		fatal = 1;
		}
		}
		mutex_unlock(&ep->com.mutex);
		if (fatal)
		release_ep_resources(ep);