Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8716273c authored by David Rientjes's avatar David Rientjes Committed by Ingo Molnar
Browse files

x86: Export srat physical topology 



This is the counterpart to "x86: export k8 physical topology" for
SRAT. It is not as invasive because the acpi code already seperates
node setup into detection and registration steps, with the
exception of registering e820 active regions in
acpi_numa_memory_affinity_init().  This is now moved to
acpi_scan_nodes() if NUMA emulation is disabled or deferred.

acpi_numa_init() now returns a value which specifies whether an
underlying SRAT was located.  If so, that topology can be used by
the emulation code to interleave emulated nodes over physical nodes
or to register the nodes for ACPI.

acpi_get_nodes() may now be used to export the srat physical
topology of the machine for NUMA emulation.

Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Ankita Garg <ankita@in.ibm.com>
Cc: Len Brown <len.brown@intel.com>
LKML-Reference: <alpine.DEB.1.00.0909251518580.14754@chino.kir.corp.google.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 8ee2debc

arch/x86/include/asm/acpi.h

+1 −0
Original line number Diff line number Diff line
@@ -158,6 +158,7 @@ struct bootnode; 


#ifdef CONFIG_ACPI_NUMA

extern int acpi_numa;

extern int acpi_get_nodes(struct bootnode *physnodes);

extern int acpi_scan_nodes(unsigned long start, unsigned long end);

#define NR_NODE_MEMBLKS (MAX_NUMNODES*2)

extern void acpi_fake_nodes(const struct bootnode *fake_nodes,

arch/x86/kernel/setup.c

+3 −2
Original line number Diff line number Diff line
@@ -938,10 +938,11 @@ void __init setup_arch(char **cmdline_p) 
	/*

	 * Parse SRAT to discover nodes.

	 */

	acpi_numa_init();

	acpi = acpi_numa_init();

#endif



#ifdef CONFIG_K8_NUMA

	if (!acpi)

		k8 = !k8_numa_init(0, max_pfn);

#endif

arch/x86/mm/numa_64.c

+2 −2
Original line number Diff line number Diff line
@@ -540,7 +540,7 @@ void __init initmem_init(unsigned long start_pfn, unsigned long last_pfn, 
#endif



#ifdef CONFIG_ACPI_NUMA

	if (!numa_off && !acpi_scan_nodes(start_pfn << PAGE_SHIFT,

	if (!numa_off && acpi && !acpi_scan_nodes(start_pfn << PAGE_SHIFT,

						  last_pfn << PAGE_SHIFT))

		return;

	nodes_clear(node_possible_map);

arch/x86/mm/srat_64.c

+21 −7
Original line number Diff line number Diff line
@@ -290,8 +290,6 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma) 


	printk(KERN_INFO "SRAT: Node %u PXM %u %lx-%lx\n", node, pxm,

	       start, end);

	e820_register_active_regions(node, start >> PAGE_SHIFT,

				     end >> PAGE_SHIFT);



	if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {

		update_nodes_add(node, start, end);
@@ -338,6 +336,19 @@ static int __init nodes_cover_memory(const struct bootnode *nodes) 


void __init acpi_numa_arch_fixup(void) {}



int __init acpi_get_nodes(struct bootnode *physnodes)

{

	int i;

	int ret = 0;



	for_each_node_mask(i, nodes_parsed) {

		physnodes[ret].start = nodes[i].start;

		physnodes[ret].end = nodes[i].end;

		ret++;

	}

	return ret;

}



/* Use the information discovered above to actually set up the nodes. */

int __init acpi_scan_nodes(unsigned long start, unsigned long end)

{
@@ -350,11 +361,6 @@ int __init acpi_scan_nodes(unsigned long start, unsigned long end) 
	for (i = 0; i < MAX_NUMNODES; i++)

		cutoff_node(i, start, end);



	if (!nodes_cover_memory(nodes)) {

		bad_srat();

		return -1;

	}



	memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks,

					   memblk_nodeid);

	if (memnode_shift < 0) {
@@ -364,6 +370,14 @@ int __init acpi_scan_nodes(unsigned long start, unsigned long end) 
		return -1;

	}



	for_each_node_mask(i, nodes_parsed)

		e820_register_active_regions(i, nodes[i].start >> PAGE_SHIFT,

						nodes[i].end >> PAGE_SHIFT);

	if (!nodes_cover_memory(nodes)) {

		bad_srat();

		return -1;

	}



	/* Account for nodes with cpus and no memory */

	nodes_or(node_possible_map, nodes_parsed, cpu_nodes_parsed);

drivers/acpi/numa.c

+6 −4
Original line number Diff line number Diff line
@@ -283,13 +283,15 @@ acpi_table_parse_srat(enum acpi_srat_type id, 


int __init acpi_numa_init(void)

{

	int ret = 0;



	/* SRAT: Static Resource Affinity Table */

	if (!acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) {

		acpi_table_parse_srat(ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY,

				      acpi_parse_x2apic_affinity, NR_CPUS);

		acpi_table_parse_srat(ACPI_SRAT_TYPE_CPU_AFFINITY,

				      acpi_parse_processor_affinity, NR_CPUS);

		acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY,

		ret = acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY,

					    acpi_parse_memory_affinity,

					    NR_NODE_MEMBLKS);

	}
@@ -298,7 +300,7 @@ int __init acpi_numa_init(void) 
	acpi_table_parse(ACPI_SIG_SLIT, acpi_parse_slit);



	acpi_numa_arch_fixup();

	return 0;

	return ret;

}



int acpi_get_pxm(acpi_handle h)