Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8697323f authored by Arun Kumar Neelakantam's avatar Arun Kumar Neelakantam Committed by Gerrit - the friendly Code Review server
Browse files

net: qrtr: Avoid qrtr_node lookup & write lock for every rx packet 



For every rx packet acquiring qrtr_node write lock to lookup
the node id can cause the write lock contention and prone to
add the stale node pointer into list while releasing the node.

Add required node id checks and use read lock while lookup.

Change-Id: I768c19f3192263a2eb113c6366b0d68e43bde4f6
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
parent 418f4a45

net/qrtr/qrtr.c

+10 −2
Original line number Diff line number Diff line
@@ -552,13 +552,21 @@ static struct qrtr_node *qrtr_node_lookup(unsigned int nid) 
 */

static void qrtr_node_assign(struct qrtr_node *node, unsigned int nid)

{

	struct qrtr_node *tnode = NULL;

	char name[32] = {0,};



	if (nid == QRTR_EP_NID_AUTO)

		return;

	if (nid == node->nid)

		return;



	down_read(&qrtr_node_lock);

	tnode = radix_tree_lookup(&qrtr_nodes, nid);

	up_read(&qrtr_node_lock);

	if (tnode)

		return;



	down_write(&qrtr_node_lock);

	if (!radix_tree_lookup(&qrtr_nodes, nid))

	radix_tree_insert(&qrtr_nodes, nid, node);



	if (node->nid == QRTR_EP_NID_AUTO)