Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84df6495 authored by Ladislav Michl's avatar Ladislav Michl Committed by Bartlomiej Zolnierkiewicz
Browse files

video: udlfb: Remove redundant gdev variable 



gdev is not really needed as the same content can be read
from udev->dev.

Signed-off-by: default avatarLadislav Michl <ladis@linux-mips.org>
Cc: Bernie Thompson <bernie@plugable.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent acea8d5f

drivers/video/fbdev/udlfb.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -1605,7 +1605,6 @@ static int dlfb_usb_probe(struct usb_interface *interface, 
	kref_init(&dev->kref); /* matching kref_put in usb .disconnect fn */

	kref_init(&dev->kref); /* matching kref_put in usb .disconnect fn */





	dev->udev = usbdev;

	dev->udev = usbdev;

	dev->gdev = &usbdev->dev; /* our generic struct device * */

	usb_set_intfdata(interface, dev);

	usb_set_intfdata(interface, dev);





	pr_info("%s %s - serial #%s\n",

	pr_info("%s %s - serial #%s\n",
@@ -1670,7 +1669,7 @@ static void dlfb_init_framebuffer_work(struct work_struct *work) 
	int i;

	int i;





	/* allocates framebuffer driver structure, not framebuffer memory */

	/* allocates framebuffer driver structure, not framebuffer memory */

	info = framebuffer_alloc(0, dev->gdev);

	info = framebuffer_alloc(0, &dev->udev->dev);

	if (!info) {

	if (!info) {

		pr_err("framebuffer_alloc failed\n");

		pr_err("framebuffer_alloc failed\n");

		goto error;

		goto error;
@@ -1765,7 +1764,6 @@ static void dlfb_usb_disconnect(struct usb_interface *interface) 




	usb_set_intfdata(interface, NULL);

	usb_set_intfdata(interface, NULL);

	dev->udev = NULL;

	dev->udev = NULL;

	dev->gdev = NULL;





	/* if clients still have us open, will be freed on last close */

	/* if clients still have us open, will be freed on last close */

	if (dev->fb_count == 0)

	if (dev->fb_count == 0)

include/video/udlfb.h

+0 −1
Original line number Original line Diff line number Diff line
@@ -35,7 +35,6 @@ struct urb_list { 




struct dlfb_data {

struct dlfb_data {

	struct usb_device *udev;

	struct usb_device *udev;

	struct device *gdev; /* &udev->dev */

	struct fb_info *info;

	struct fb_info *info;

	struct urb_list urbs;

	struct urb_list urbs;

	struct kref kref;

	struct kref kref;