Commit 8417f5e5 authored Oct 29, 2015 by Bryan O'Donoghue Committed by Greg Kroah-Hartman Nov 02, 2015

greybus: audio-pcm: fix use of variable unitialized



Compiling with clang shows that period_elapsed will be used as a branch
conditional unitialized whenever snd_dev->transfer_done <
runtime->period_size. Since stack can grow up/down as we proceed though
the call stack this should be fixed. This patch fixes by explicitly
initalizing period_elapsed to zero.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

parent b3500072

drivers/staging/greybus/audio-pcm.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -91,6 +91,7 @@ static void gb_pcm_work(struct work_struct *work)

		frames = (len + (oldptr % stride)) / stride;

		period_elapsed = 0;
		snd_dev->transfer_done += frames;
		if (snd_dev->transfer_done >= runtime->period_size) {
		snd_dev->transfer_done -= runtime->period_size;