Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83c97fe1 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (acpi_power_meter) Don't crash the kernel unnecessarily 



acpi_power_meter crashes the kernel if it detects an unexpected event
or an internal implementation error. While the detected conditions
suggest that there is a bug in the code, the condition is not fatal.
Replace BUG() with WARN().

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent c52ae3d2

drivers/hwmon/acpi_power_meter.c

+8 −3
Original line number Diff line number Diff line
@@ -381,8 +381,10 @@ static ssize_t show_str(struct device *dev, 
		val = resource->oem_info;

		break;

	default:

		BUG();

		WARN(1, "Implementation error: unexpected attribute index %d\n",

		     attr->index);

		val = "";

		break;

	}



	return sprintf(buf, "%s\n", val);
@@ -436,7 +438,9 @@ static ssize_t show_val(struct device *dev, 
		val = resource->trip[attr->index - 7] * 1000;

		break;

	default:

		BUG();

		WARN(1, "Implementation error: unexpected attribute index %d\n",

		     attr->index);

		break;

	}



	return sprintf(buf, "%llu\n", val);
@@ -855,7 +859,8 @@ static void acpi_power_meter_notify(struct acpi_device *device, u32 event) 
		dev_info(&device->dev, "Capping in progress.\n");

		break;

	default:

		BUG();

		WARN(1, "Unexpected event %d\n", event);

		break;

	}

	mutex_unlock(&resource->lock);