Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8380b74e authored Jul 30, 2018 by Kamal Heib Committed by Jason Gunthorpe Jul 30, 2018

RDMA/providers: Fix return value from create_srq callbacks



The proper return code is "-EOPNOTSUPP" when the create_srq() callback
is not supported.

Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent f95ccffc

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1397,7 +1397,7 @@ struct ib_srq bnxt_re_create_srq(struct ib_pd ib_pd,
	}		}

	if (srq_init_attr->srq_type != IB_SRQT_BASIC) {		if (srq_init_attr->srq_type != IB_SRQT_BASIC) {
	rc = -ENOTSUPP;		rc = -EOPNOTSUPP;
	goto exit;		goto exit;
	}		}

drivers/infiniband/hw/mthca/mthca_provider.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -449,7 +449,7 @@ static struct ib_srq mthca_create_srq(struct ib_pd pd,
	int err;		int err;

	if (init_attr->srq_type != IB_SRQT_BASIC)		if (init_attr->srq_type != IB_SRQT_BASIC)
	return ERR_PTR(-ENOSYS);		return ERR_PTR(-EOPNOTSUPP);

	srq = kmalloc(sizeof *srq, GFP_KERNEL);		srq = kmalloc(sizeof *srq, GFP_KERNEL);
	if (!srq)		if (!srq)

drivers/infiniband/sw/rdmavt/srq.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -82,7 +82,7 @@ struct ib_srq rvt_create_srq(struct ib_pd ibpd,
	struct ib_srq *ret;		struct ib_srq *ret;

	if (srq_init_attr->srq_type != IB_SRQT_BASIC)		if (srq_init_attr->srq_type != IB_SRQT_BASIC)
	return ERR_PTR(-ENOSYS);		return ERR_PTR(-EOPNOTSUPP);

	if (srq_init_attr->attr.max_sge == 0 \|\|		if (srq_init_attr->attr.max_sge == 0 \|\|
	srq_init_attr->attr.max_sge > dev->dparms.props.max_srq_sge \|\|		srq_init_attr->attr.max_sge > dev->dparms.props.max_srq_sge \|\|