Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83331040 authored by Tomoya MORINAGA's avatar Tomoya MORINAGA Committed by Felipe Balbi
Browse files

usb: gadget: pch_udc: Reduce redundant interrupt 



ISSUE:
USB Suspend interrupts occur frequently.

CAUSE:
When it is called pch_udc_reconnect() in USB Suspend, it repeats reset and
Suspend.

SOLUTION:
pch_udc_reconnect() does not enable all interrupts.  When an enumeration event
occurred the driver enables all interrupts.

Signed-off-by: default avatarTomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 1c575d2d

drivers/usb/gadget/pch_udc.c

+6 −3
Original line number Original line Diff line number Diff line
@@ -568,9 +568,7 @@ static void pch_udc_reconnect(struct pch_udc_dev *dev) 
	/* enable device interrupts */

	/* enable device interrupts */

	/* pch_udc_enable_interrupts() */

	/* pch_udc_enable_interrupts() */

	pch_udc_bit_clr(dev, UDC_DEVIRQMSK_ADDR,

	pch_udc_bit_clr(dev, UDC_DEVIRQMSK_ADDR,

			UDC_DEVINT_UR | UDC_DEVINT_US |

			UDC_DEVINT_UR | UDC_DEVINT_ENUM);

			UDC_DEVINT_ENUM |

			UDC_DEVINT_SI | UDC_DEVINT_SC);





	/* Clear the disconnect */

	/* Clear the disconnect */

	pch_udc_bit_set(dev, UDC_DEVCTL_ADDR, UDC_DEVCTL_RES);

	pch_udc_bit_set(dev, UDC_DEVCTL_ADDR, UDC_DEVCTL_RES);
@@ -2419,6 +2417,11 @@ static void pch_udc_svc_enum_interrupt(struct pch_udc_dev *dev) 
	pch_udc_set_dma(dev, DMA_DIR_TX);

	pch_udc_set_dma(dev, DMA_DIR_TX);

	pch_udc_set_dma(dev, DMA_DIR_RX);

	pch_udc_set_dma(dev, DMA_DIR_RX);

	pch_udc_ep_set_rrdy(&(dev->ep[UDC_EP0OUT_IDX]));

	pch_udc_ep_set_rrdy(&(dev->ep[UDC_EP0OUT_IDX]));



	/* enable device interrupts */

	pch_udc_enable_interrupts(dev, UDC_DEVINT_UR | UDC_DEVINT_US |

					UDC_DEVINT_ES | UDC_DEVINT_ENUM |

					UDC_DEVINT_SI | UDC_DEVINT_SC);

}

}





/**

/**