Commit 82edcc75 authored Apr 10, 2018 by Jia-Ju Bai Committed by Jon Mason Jun 11, 2018

ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw



ntb_transport_setup_qp_mw() is never called in atomic context.

ntb_transport_setup_qp_mw() is only called by ntb_transport_link_work(),
which is set as a parameter of INIT_DELAYED_WORK()
in ntb_transport_probe().

Despite never getting called from atomic context,
ntb_transport_setup_qp_mw() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>

parent 081a6986

drivers/ntb/ntb_transport.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -637,7 +637,7 @@ static int ntb_transport_setup_qp_mw(struct ntb_transport_ctx *nt,
	*/		*/
	node = dev_to_node(&ndev->dev);		node = dev_to_node(&ndev->dev);
	for (i = qp->rx_alloc_entry; i < qp->rx_max_entry; i++) {		for (i = qp->rx_alloc_entry; i < qp->rx_max_entry; i++) {
	entry = kzalloc_node(sizeof(*entry), GFP_ATOMIC, node);		entry = kzalloc_node(sizeof(*entry), GFP_KERNEL, node);
	if (!entry)		if (!entry)
	return -ENOMEM;		return -ENOMEM;