Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8179de98 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

siano: get rid of an unused return code for debugfs register 



The siano's debugfs register logic is optional: it should be ok
if it fails. So, no need to check if debufs register succeeded.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 6c33d826

drivers/media/common/siano/smsdvb-debugfs.c

+5 −5
Original line number Diff line number Diff line
@@ -500,7 +500,7 @@ void smsdvb_debugfs_release(struct smsdvb_client_t *client) 
	client->debugfs = NULL;

}



int smsdvb_debugfs_register(void)

void smsdvb_debugfs_register(void)

{

	struct dentry *d;
@@ -517,15 +517,15 @@ int smsdvb_debugfs_register(void) 
	d = debugfs_create_dir("smsdvb", usb_debug_root);

	if (IS_ERR_OR_NULL(d)) {

		pr_err("Couldn't create sysfs node for smsdvb\n");

		return PTR_ERR(d);

	} else {

		smsdvb_debugfs_usb_root = d;

		return;

	}

	return 0;

	smsdvb_debugfs_usb_root = d;

}



void smsdvb_debugfs_unregister(void)

{

	if (!smsdvb_debugfs_usb_root)

		return;

	debugfs_remove_recursive(smsdvb_debugfs_usb_root);

	smsdvb_debugfs_usb_root = NULL;

}

drivers/media/common/siano/smsdvb.h

+2 −5
Original line number Diff line number Diff line
@@ -107,7 +107,7 @@ struct RECEPTION_STATISTICS_PER_SLICES_S { 


int smsdvb_debugfs_create(struct smsdvb_client_t *client);

void smsdvb_debugfs_release(struct smsdvb_client_t *client);

int smsdvb_debugfs_register(void);

void smsdvb_debugfs_register(void);

void smsdvb_debugfs_unregister(void);



#else
@@ -119,10 +119,7 @@ static inline int smsdvb_debugfs_create(struct smsdvb_client_t *client) 


static inline void smsdvb_debugfs_release(struct smsdvb_client_t *client) {}



static inline int smsdvb_debugfs_register(void)

{

	return 0;

};

static inline void smsdvb_debugfs_register(void) {}



static inline void smsdvb_debugfs_unregister(void) {};