Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 811d7e02 authored by Guenter Roeck's avatar Guenter Roeck Committed by Greg Kroah-Hartman
Browse files

firmware: vpd: Destroy vpd sections in remove function 



vpd sections are initialized during probe and thus should be destroyed
in the remove function.

Fixes: 049a59db ("firmware: Google VPD sysfs driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 297d6b6e

drivers/firmware/google/vpd.c

+9 −2
Original line number Diff line number Diff line
@@ -298,8 +298,17 @@ static int vpd_probe(struct platform_device *pdev) 
	return vpd_sections_init(entry.cbmem_addr);

}



static int vpd_remove(struct platform_device *pdev)

{

	vpd_section_destroy(&ro_vpd);

	vpd_section_destroy(&rw_vpd);



	return 0;

}



static struct platform_driver vpd_driver = {

	.probe = vpd_probe,

	.remove = vpd_remove,

	.driver = {

		.name = "vpd",

	},
@@ -324,8 +333,6 @@ static int __init vpd_platform_init(void) 


static void __exit vpd_platform_exit(void)

{

	vpd_section_destroy(&ro_vpd);

	vpd_section_destroy(&rw_vpd);

	kobject_put(vpd_kobj);

}