Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8017e422 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/scdc-helper: Convert errors into debug messages 



Since we may attempt to reconfigure SCDC when the sink has already been
disconnected we probably shouldn't scare the user with errors in dmesg
that are 100% expected in that case. Just leave it up to the caller
whether to print an error message or not, and just output debug
messages from the helper itself.

Cc: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180323182537.30784-1-ville.syrjala@linux.intel.com


Reviewed-by: default avatarShashank Sharma <shashank.sharma@intel.com>
parent 39031176

drivers/gpu/drm/drm_scdc_helper.c

+5 −5
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) 


	ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status);

	if (ret < 0) {

		DRM_ERROR("Failed to read scrambling status: %d\n", ret);

		DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret);

		return false;

	}
@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) 


	ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config);

	if (ret < 0) {

		DRM_ERROR("Failed to read TMDS config: %d\n", ret);

		DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret);

		return false;

	}
@@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) 


	ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config);

	if (ret < 0) {

		DRM_ERROR("Failed to enable scrambling: %d\n", ret);

		DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret);

		return false;

	}
@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) 


	ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config);

	if (ret < 0) {

		DRM_ERROR("Failed to read TMDS config: %d\n", ret);

		DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret);

		return false;

	}
@@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) 


	ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config);

	if (ret < 0) {

		DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret);

		DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret);

		return false;

	}