Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fb2fd4e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

vmci: type promotion bug in qp_host_get_user_memory() 



The problem is that if get_user_pages_fast() fails and returns a
negative error code, it gets type promoted to a high positive value and
treated as a success.

Fixes: 06164d2b ("VMCI: queue pairs implementation.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fc82975a

drivers/misc/vmw_vmci/vmci_queue_pair.c

+2 −2
Original line number Diff line number Diff line
@@ -668,7 +668,7 @@ static int qp_host_get_user_memory(u64 produce_uva, 
	retval = get_user_pages_fast((uintptr_t) produce_uva,

				     produce_q->kernel_if->num_pages, 1,

				     produce_q->kernel_if->u.h.header_page);

	if (retval < produce_q->kernel_if->num_pages) {

	if (retval < (int)produce_q->kernel_if->num_pages) {

		pr_debug("get_user_pages_fast(produce) failed (retval=%d)",

			retval);

		qp_release_pages(produce_q->kernel_if->u.h.header_page,
@@ -680,7 +680,7 @@ static int qp_host_get_user_memory(u64 produce_uva, 
	retval = get_user_pages_fast((uintptr_t) consume_uva,

				     consume_q->kernel_if->num_pages, 1,

				     consume_q->kernel_if->u.h.header_page);

	if (retval < consume_q->kernel_if->num_pages) {

	if (retval < (int)consume_q->kernel_if->num_pages) {

		pr_debug("get_user_pages_fast(consume) failed (retval=%d)",

			retval);

		qp_release_pages(consume_q->kernel_if->u.h.header_page,