Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f144fd0 authored by Junichi Uekawa's avatar Junichi Uekawa Committed by Theodore Ts'o
Browse files

ext4: fix warning message in ext4_enable_quotas() 



Output the warning message before we clobber type and be -1 all the time.
The error message would now be

[    1.519791] EXT4-fs warning (device vdb): ext4_enable_quotas:5402:
Failed to enable quota tracking (type=0, err=-3). Please run e2fsck to fix.

Signed-off-by: default avatarJunichi Uekawa <uekawa@google.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
parent 6a0678a7

fs/ext4/super.c

+3 −3
Original line number Diff line number Diff line
@@ -5686,13 +5686,13 @@ static int ext4_enable_quotas(struct super_block *sb) 
				DQUOT_USAGE_ENABLED |

				(quota_mopt[type] ? DQUOT_LIMITS_ENABLED : 0));

			if (err) {

				for (type--; type >= 0; type--)

					dquot_quota_off(sb, type);



				ext4_warning(sb,

					"Failed to enable quota tracking "

					"(type=%d, err=%d). Please run "

					"e2fsck to fix.", type, err);

				for (type--; type >= 0; type--)

					dquot_quota_off(sb, type);



				return err;

			}

		}