Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d875a02 authored by Anders Kaseorg's avatar Anders Kaseorg Committed by Sam Ravnborg
Browse files

kbuild, modpost: fix unexpected non-allocatable section when cross compiling 



The missing TO_NATIVE(sechdrs[i].sh_flags) was causing many
unexpected non-allocatable section warnings when cross-compiling
for an architecture with a different endianness.

Fix endianness of all the fields in the ELF header and
section headers, not just some of them so we are not
hit by this anohter time.

Signed-off-by: default avatarAnders Kaseorg <andersk@mit.edu>
Reported-by: default avatarSean MacLennan <smaclennan@pikatech.com>
Tested-by: default avatarSean MacLennan <smaclennan@pikatech.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
parent b4348f32

scripts/mod/modpost.c

+23 −12
Original line number Diff line number Diff line
@@ -384,11 +384,19 @@ static int parse_elf(struct elf_info *info, const char *filename) 
		return 0;

	}

	/* Fix endianness in ELF header */

	hdr->e_type      = TO_NATIVE(hdr->e_type);

	hdr->e_machine   = TO_NATIVE(hdr->e_machine);

	hdr->e_version   = TO_NATIVE(hdr->e_version);

	hdr->e_entry     = TO_NATIVE(hdr->e_entry);

	hdr->e_phoff     = TO_NATIVE(hdr->e_phoff);

	hdr->e_shoff     = TO_NATIVE(hdr->e_shoff);

	hdr->e_shstrndx = TO_NATIVE(hdr->e_shstrndx);

	hdr->e_flags     = TO_NATIVE(hdr->e_flags);

	hdr->e_ehsize    = TO_NATIVE(hdr->e_ehsize);

	hdr->e_phentsize = TO_NATIVE(hdr->e_phentsize);

	hdr->e_phnum     = TO_NATIVE(hdr->e_phnum);

	hdr->e_shentsize = TO_NATIVE(hdr->e_shentsize);

	hdr->e_shnum     = TO_NATIVE(hdr->e_shnum);

	hdr->e_machine  = TO_NATIVE(hdr->e_machine);

	hdr->e_type     = TO_NATIVE(hdr->e_type);

	hdr->e_shstrndx  = TO_NATIVE(hdr->e_shstrndx);

	sechdrs = (void *)hdr + hdr->e_shoff;

	info->sechdrs = sechdrs;
@@ -402,13 +410,16 @@ static int parse_elf(struct elf_info *info, const char *filename) 


	/* Fix endianness in section headers */

	for (i = 0; i < hdr->e_shnum; i++) {

		sechdrs[i].sh_name      = TO_NATIVE(sechdrs[i].sh_name);

		sechdrs[i].sh_type      = TO_NATIVE(sechdrs[i].sh_type);

		sechdrs[i].sh_flags     = TO_NATIVE(sechdrs[i].sh_flags);

		sechdrs[i].sh_addr      = TO_NATIVE(sechdrs[i].sh_addr);

		sechdrs[i].sh_offset    = TO_NATIVE(sechdrs[i].sh_offset);

		sechdrs[i].sh_size      = TO_NATIVE(sechdrs[i].sh_size);

		sechdrs[i].sh_link      = TO_NATIVE(sechdrs[i].sh_link);

		sechdrs[i].sh_name   = TO_NATIVE(sechdrs[i].sh_name);

		sechdrs[i].sh_info      = TO_NATIVE(sechdrs[i].sh_info);

		sechdrs[i].sh_addr   = TO_NATIVE(sechdrs[i].sh_addr);

		sechdrs[i].sh_addralign = TO_NATIVE(sechdrs[i].sh_addralign);

		sechdrs[i].sh_entsize   = TO_NATIVE(sechdrs[i].sh_entsize);

	}

	/* Find symbol table. */

	for (i = 1; i < hdr->e_shnum; i++) {