Commit 7c2d176f authored Apr 14, 2017 by Kuppuswamy Sathyanarayanan Committed by Linus Walleij Apr 24, 2017

gpio: gpio-wcove: fix irq pending status bit width

Whiskey cove PMIC has three GPIO banks with total number of 13 GPIO
pins. But when checking for the pending status, for_each_set_bit() uses
bit width of 7 and hence it only checks the status for first 7 GPIO pins
missing to check/clear the status of rest of the GPIO pins. This patch
fixes this issue.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 5664aa1c

drivers/gpio/gpio-wcove.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -317,7 +317,7 @@ static irqreturn_t wcove_gpio_irq_handler(int irq, void *data)
		while (pending) {
		/* One iteration is for all pending bits */
		for_each_set_bit(gpio, (const unsigned long *)&pending,
		GROUP0_NR_IRQS) {
		WCOVE_GPIO_NUM) {
		offset = (gpio > GROUP0_NR_IRQS) ? 1 : 0;
		mask = (offset == 1) ? BIT(gpio - GROUP0_NR_IRQS) :
		BIT(gpio);