Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b52e279 authored by Steve French's avatar Steve French
Browse files

Allow copy offload (CopyChunk) across shares 



FSCTL_SRV_COPYCHUNK_WRITE only requires that the source and target
be on the same server (not the same volume or same share),
so relax the existing check (which required them to be on
the same share). Note that this works to Windows (and presumably
most other NAS) but Samba requires that the source
and target be on the same share.  Moving a file across
shares is a common use case and can be very heplful (100x faster).

Signed-off-by: default avatarSteve French <steve.french@primarydata.com>
Reviewed-by: default avatarDavid Disseldorp <ddiss@samba.org>
parent 592fafe6

fs/cifs/cifsfs.c

+0 −12
Original line number Diff line number Diff line
@@ -925,9 +925,7 @@ const struct file_operations cifs_file_ops = { 
	.mmap  = cifs_file_mmap,

	.splice_read = generic_file_splice_read,

	.llseek = cifs_llseek,

#ifdef CONFIG_CIFS_POSIX

	.unlocked_ioctl	= cifs_ioctl,

#endif /* CONFIG_CIFS_POSIX */

	.setlease = cifs_setlease,

	.fallocate = cifs_fallocate,

};
@@ -943,9 +941,7 @@ const struct file_operations cifs_file_strict_ops = { 
	.mmap = cifs_file_strict_mmap,

	.splice_read = generic_file_splice_read,

	.llseek = cifs_llseek,

#ifdef CONFIG_CIFS_POSIX

	.unlocked_ioctl	= cifs_ioctl,

#endif /* CONFIG_CIFS_POSIX */

	.setlease = cifs_setlease,

	.fallocate = cifs_fallocate,

};
@@ -961,9 +957,7 @@ const struct file_operations cifs_file_direct_ops = { 
	.flush = cifs_flush,

	.mmap = cifs_file_mmap,

	.splice_read = generic_file_splice_read,

#ifdef CONFIG_CIFS_POSIX

	.unlocked_ioctl  = cifs_ioctl,

#endif /* CONFIG_CIFS_POSIX */

	.llseek = cifs_llseek,

	.setlease = cifs_setlease,

	.fallocate = cifs_fallocate,
@@ -979,9 +973,7 @@ const struct file_operations cifs_file_nobrl_ops = { 
	.mmap  = cifs_file_mmap,

	.splice_read = generic_file_splice_read,

	.llseek = cifs_llseek,

#ifdef CONFIG_CIFS_POSIX

	.unlocked_ioctl	= cifs_ioctl,

#endif /* CONFIG_CIFS_POSIX */

	.setlease = cifs_setlease,

	.fallocate = cifs_fallocate,

};
@@ -996,9 +988,7 @@ const struct file_operations cifs_file_strict_nobrl_ops = { 
	.mmap = cifs_file_strict_mmap,

	.splice_read = generic_file_splice_read,

	.llseek = cifs_llseek,

#ifdef CONFIG_CIFS_POSIX

	.unlocked_ioctl	= cifs_ioctl,

#endif /* CONFIG_CIFS_POSIX */

	.setlease = cifs_setlease,

	.fallocate = cifs_fallocate,

};
@@ -1013,9 +1003,7 @@ const struct file_operations cifs_file_direct_nobrl_ops = { 
	.flush = cifs_flush,

	.mmap = cifs_file_mmap,

	.splice_read = generic_file_splice_read,

#ifdef CONFIG_CIFS_POSIX

	.unlocked_ioctl  = cifs_ioctl,

#endif /* CONFIG_CIFS_POSIX */

	.llseek = cifs_llseek,

	.setlease = cifs_setlease,

	.fallocate = cifs_fallocate,

fs/cifs/ioctl.c

+8 −3
Original line number Diff line number Diff line
@@ -85,9 +85,14 @@ static long cifs_ioctl_clone(unsigned int xid, struct file *dst_file, 
	src_tcon = tlink_tcon(smb_file_src->tlink);

	target_tcon = tlink_tcon(smb_file_target->tlink);



	/* check if source and target are on same tree connection */

	if (src_tcon != target_tcon) {

		cifs_dbg(VFS, "file copy src and target on different volume\n");

	/* check source and target on same server (or volume if dup_extents) */

	if (dup_extents && (src_tcon != target_tcon)) {

		cifs_dbg(VFS, "source and target of copy not on same share\n");

		goto out_fput;

	}



	if (!dup_extents && (src_tcon->ses != target_tcon->ses)) {

		cifs_dbg(VFS, "source and target of copy not on same server\n");

		goto out_fput;

	}