Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7977df39 authored by Harshdeep Dhatt's avatar Harshdeep Dhatt
Browse files

msm: kgsl: Omit referencing pointers in traces 



Trace points should not store pointers in the trace data because
they could be dereferenced much later after the original memory
has disappeared.

Change-Id: I9f134bcdaa39c437394c3552aaacd8a360924200
Signed-off-by: default avatarHarshdeep Dhatt <hdhatt@codeaurora.org>
parent 5ee5dd9a

drivers/gpu/msm/adreno_trace.h

+11 −11
Original line number Original line Diff line number Diff line 
/* Copyright (c) 2013-2018, The Linux Foundation. All rights reserved.

/* Copyright (c) 2013-2019, The Linux Foundation. All rights reserved.

 *

 *

 * This program is free software; you can redistribute it and/or modify

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and

 * it under the terms of the GNU General Public License version 2 and
@@ -577,17 +577,17 @@ TRACE_EVENT(adreno_preempt_trigger, 
		unsigned int cntl),

		unsigned int cntl),

	TP_ARGS(cur, next, cntl),

	TP_ARGS(cur, next, cntl),

	TP_STRUCT__entry(

	TP_STRUCT__entry(

		__field(struct adreno_ringbuffer *, cur)

		__field(unsigned int, cur)

		__field(struct adreno_ringbuffer *, next)

		__field(unsigned int, next)

		__field(unsigned int, cntl)

		__field(unsigned int, cntl)

	),

	),

	TP_fast_assign(

	TP_fast_assign(

		__entry->cur = cur;

		__entry->cur = cur->id;

		__entry->next = next;

		__entry->next = next->id;

		__entry->cntl = cntl;

		__entry->cntl = cntl;

	),

	),

	TP_printk("trigger from id=%d to id=%d cntl=%x",

	TP_printk("trigger from id=%d to id=%d cntl=%x",

		__entry->cur->id, __entry->next->id, __entry->cntl

		__entry->cur, __entry->next, __entry->cntl

	)

	)

);

);
@@ -596,17 +596,17 @@ TRACE_EVENT(adreno_preempt_done, 
		unsigned int level),

		unsigned int level),

	TP_ARGS(cur, next, level),

	TP_ARGS(cur, next, level),

	TP_STRUCT__entry(

	TP_STRUCT__entry(

		__field(struct adreno_ringbuffer *, cur)

		__field(unsigned int, cur)

		__field(struct adreno_ringbuffer *, next)

		__field(unsigned int, next)

		__field(unsigned int, level)

		__field(unsigned int, level)

	),

	),

	TP_fast_assign(

	TP_fast_assign(

		__entry->cur = cur;

		__entry->cur = cur->id;

		__entry->next = next;

		__entry->next = next->id;

		__entry->level = level;

		__entry->level = level;

	),

	),

	TP_printk("done switch to id=%d from id=%d level=%x",

	TP_printk("done switch to id=%d from id=%d level=%x",

		__entry->next->id, __entry->cur->id, __entry->level

		__entry->next, __entry->cur, __entry->level

	)

	)

);

);