Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78389046 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd4: warn on odd create_session state 



This should never happen.

(Note: the comparable case in setclientid_confirm *can* happen, since
updating a client record can result in both confirmed and unconfirmed
records with the same clientid.)

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 491402a7

fs/nfsd/nfs4state.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -1788,6 +1788,7 @@ nfsd4_create_session(struct svc_rqst *rqstp, 
	nfs4_lock_state();

	nfs4_lock_state();

	unconf = find_unconfirmed_client(&cr_ses->clientid, true, nn);

	unconf = find_unconfirmed_client(&cr_ses->clientid, true, nn);

	conf = find_confirmed_client(&cr_ses->clientid, true, nn);

	conf = find_confirmed_client(&cr_ses->clientid, true, nn);

	WARN_ON_ONCE(conf && unconf);





	if (conf) {

	if (conf) {

		cs_slot = &conf->cl_cs_slot;

		cs_slot = &conf->cl_cs_slot;
@@ -2129,6 +2130,7 @@ nfsd4_destroy_clientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *csta 
	nfs4_lock_state();

	nfs4_lock_state();

	unconf = find_unconfirmed_client(&dc->clientid, true, nn);

	unconf = find_unconfirmed_client(&dc->clientid, true, nn);

	conf = find_confirmed_client(&dc->clientid, true, nn);

	conf = find_confirmed_client(&dc->clientid, true, nn);

	WARN_ON_ONCE(conf && unconf);





	if (conf) {

	if (conf) {

		clp = conf;

		clp = conf;