Commit 778e3a4e authored Jul 20, 2020 by Wang Yufen Committed by Greg Kroah-Hartman Oct 30, 2020

brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach



[ Upstream commit 6c151410d5b57e6bb0d91a735ac511459539a7bf ]

When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
we should destroy the workqueue.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1595237765-66238-1-git-send-email-wangyufen@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0484e56f

drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1563,6 +1563,8 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)
		BRCMF_TX_IOCTL_MAX_MSG_SIZE,
		msgbuf->ioctbuf,
		msgbuf->ioctbuf_handle);
		if (msgbuf->txflow_wq)
		destroy_workqueue(msgbuf->txflow_wq);
		kfree(msgbuf);
		}
		return -ENOMEM;