Commit 752dc185 authored Jun 02, 2012 by Hugh Dickins Committed by Linus Torvalds Jun 03, 2012

mm: fix warning in __set_page_dirty_nobuffers

New tmpfs use of !PageUptodate pages for fallocate() is triggering the
WARNING: at mm/page-writeback.c:1990 when __set_page_dirty_nobuffers()
is called from migrate_page_copy() for compaction.

It is anomalous that migration should use __set_page_dirty_nobuffers()
on an address_space that does not participate in dirty and writeback
accounting; and this has also been observed to insert surprising dirty
tags into a tmpfs radix_tree, despite tmpfs not using tags at all.

We should probably give migrate_page_copy() a better way to preserve the
tag and migrate accounting info, when mapping_cap_account_dirty(). But
that needs some more work: so in the interim, avoid the warning by using
a simple SetPageDirty on PageSwapBacked pages.

Reported-and-tested-by: Dave Jones <davej@redhat.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2f9d3df8

mm/migrate.c

+4 −1

Original line number	Original line	Diff line number	Diff line
	@@ -436,6 +436,9 @@ void migrate_page_copy(struct page newpage, struct page page)
	* is actually a signal that all of the page has become dirty.		* is actually a signal that all of the page has become dirty.
	* Whereas only part of our page may be dirty.		* Whereas only part of our page may be dirty.
	*/		*/
			if (PageSwapBacked(page))
			SetPageDirty(newpage);
			else
	__set_page_dirty_nobuffers(newpage);		__set_page_dirty_nobuffers(newpage);
	}		}