Commit 73dcc666 authored Mar 29, 2018 by Geert Uytterhoeven Committed by Vinod Koul Apr 04, 2018

dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks



If serial console wake-up is enabled ("echo enabled >
/sys/.../ttySC0/power/wakeup"), and any serial input is received while
the system is suspended, serial port input no longer works after system
resume.

Note that:
  1) The system can still be woken up using the serial console,
  2) Serial port input keeps working if the system is woken up in some
     other way (e.g. Wake-on-LAN or gpio-keys), and no serial input was
     received while suspended.

To fix this, replace SET_LATE_SYSTEM_SLEEP_PM_OPS() by
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), as the callbacks installed by the
former happen too early resp. late in the suspend resp. resume process.

Reported-by: RVC test team via Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fixes: 1131b0a4 ("dmaengine: rcar-dmac: Make DMAC reinit during system resume explicit")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 3e081628

drivers/dma/sh/rcar-dmac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1686,7 +1686,7 @@ static const struct dev_pm_ops rcar_dmac_pm = {
		* - Wait for the current transfer to complete and stop the device,
		* - Resume transfers, if any.
		*/
		SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
		SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
		pm_runtime_force_resume)
		SET_RUNTIME_PM_OPS(rcar_dmac_runtime_suspend, rcar_dmac_runtime_resume,
		NULL)