Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 730b2ad8 authored by Sibi Sankar's avatar Sibi Sankar Committed by Bjorn Andersson
Browse files

remoteproc: fix null pointer dereference on glink only platforms 



Currently calling list_del on smd subdev remove path results in
null pointer dereference on glink only platforms. Fix this by
adding safety checks in glink/smd subdev remove paths.

Signed-off-by: default avatarSibi Sankar <sibis@codeaurora.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent dea4bd19

drivers/remoteproc/qcom_common.c

+6 −0
Original line number Diff line number Diff line
@@ -75,6 +75,9 @@ EXPORT_SYMBOL_GPL(qcom_add_glink_subdev); 
 */

void qcom_remove_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink)

{

	if (!glink->node)

		return;



	rproc_remove_subdev(rproc, &glink->subdev);

	of_node_put(glink->node);

}
@@ -165,6 +168,9 @@ EXPORT_SYMBOL_GPL(qcom_add_smd_subdev); 
 */

void qcom_remove_smd_subdev(struct rproc *rproc, struct qcom_rproc_subdev *smd)

{

	if (!smd->node)

		return;



	rproc_remove_subdev(rproc, &smd->subdev);

	of_node_put(smd->node);

}