Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72c6fb4f authored by Andy Lutomirski's avatar Andy Lutomirski Committed by Ingo Molnar
Browse files

x86/ia32-compat: Fix CLONE_SETTLS bitness of copy_thread() 



CLONE_SETTLS is expected to write a TLS entry in the GDT for
32-bit callers and to set FSBASE for 64-bit callers.

The correct check is is_ia32_task(), which returns true in the
context of a 32-bit syscall.  TIF_IA32 is set if the task itself
has a 32-bit personality, which is not the same thing.

Signed-off-by: default avatarAndy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Link: http://lkml.kernel.org/r/45e2d0d695393d76406a0c7225b82c76223e0cc5.1424822291.git.luto@amacapital.net


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 08571f1a

arch/x86/kernel/process_64.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, 
	 */

	if (clone_flags & CLONE_SETTLS) {

#ifdef CONFIG_IA32_EMULATION

		if (test_thread_flag(TIF_IA32))

		if (is_ia32_task())

			err = do_set_thread_area(p, -1,

				(struct user_desc __user *)childregs->si, 0);

		else