Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 721ce0f6 authored by Subash Abhinov Kasiviswanathan's avatar Subash Abhinov Kasiviswanathan Committed by David S. Miller
Browse files

net: qualcomm: rmnet: Remove redundant command check 



The command packet size is already checked once in
rmnet_map_deaggregate() for the header, packet and trailer size, so
this additional check is not needed.

Signed-off-by: default avatarSubash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bbde32d3

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

+3 −11
Original line number Diff line number Diff line
@@ -69,17 +69,9 @@ static void rmnet_map_send_ack(struct sk_buff *skb, 
	struct rmnet_map_control_command *cmd;

	int xmit_status;



	if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4) {

		if (skb->len < sizeof(struct rmnet_map_header) +

		    RMNET_MAP_GET_LENGTH(skb) +

		    sizeof(struct rmnet_map_dl_csum_trailer)) {

			kfree_skb(skb);

			return;

		}



		skb_trim(skb, skb->len -

			 sizeof(struct rmnet_map_dl_csum_trailer));

	}

	if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4)

		skb_trim(skb,

			 skb->len - sizeof(struct rmnet_map_dl_csum_trailer));



	skb->protocol = htons(ETH_P_MAP);