Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71be8dee authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Mauro Carvalho Chehab
Browse files

media: pci: cx23885: Replace mdelay() with msleep() in cx23885_reset() 



cx23885_reset() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 9095b23f

drivers/media/pci/cx23885/cx23885-core.c

+1 −1
Original line number Diff line number Diff line
@@ -667,7 +667,7 @@ static void cx23885_reset(struct cx23885_dev *dev) 


	/* clear dma in progress */

	cx23885_clear_bridge_error(dev);

	mdelay(100);

	msleep(100);



	cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH01],

		720*4, 0);