Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71456906 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Greg Kroah-Hartman
Browse files

serial: core: mark port as initialized in autoconfig 

This is a followup on 44117a1d ("serial: core: mark port as
initialized after successful IRQ change").
Nikola has been using autoconfig via setserial and reported a crash
similar to what I fixed in the earlier mentioned commit. Here I do the
same fixup for the autoconfig. I wasn't sure that this is the right
approach. Nikola confirmed that it fixes his crash.

Fixes: b3b57646 ("tty: serial_core: convert uart_open to use tty_port_open")
Link: http://lkml.kernel.org/r/20180131072000.GD1853@localhost.localdomain


Reported-by: default avatarNikola Ciprich <nikola.ciprich@linuxbox.cz>
Tested-by: default avatarNikola Ciprich <nikola.ciprich@linuxbox.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: default avatarNikola Ciprich <nikola.ciprich@linuxbox.cz>
Acked-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e7f3e99c

drivers/tty/serial/serial_core.c

+2 −0
Original line number Diff line number Diff line
@@ -1144,6 +1144,8 @@ static int uart_do_autoconfig(struct tty_struct *tty,struct uart_state *state) 
		uport->ops->config_port(uport, flags);



		ret = uart_startup(tty, state, 1);

		if (ret == 0)

			tty_port_set_initialized(port, true);

		if (ret > 0)

			ret = 0;

	}